Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shield when re-enqueuing task runs #13883

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Add shield when re-enqueuing task runs #13883

merged 3 commits into from
Jun 7, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Jun 7, 2024 •
edited
Loading

related to #13868, we need to shield the cleanup at disconnect from cancellation

@zzstoatzz zzstoatzz marked this pull request as ready for review June 7, 2024 20:47
@zzstoatzz zzstoatzz requested review from zangell44 and a team as code owners June 7, 2024 20:47
@zzstoatzz zzstoatzz self-assigned this Jun 7, 2024
@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Jun 7, 2024
chrisguidry
chrisguidry approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zzstoatzz zzstoatzz merged commit f30a673 into main Jun 7, 2024
27 of 28 checks passed
@zzstoatzz zzstoatzz deleted the shield-reenqueue branch June 7, 2024 21:50
@zzstoatzz zzstoatzz changed the title shield reenqueue Add shield when re-enqueuing task runs Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44 zangell44 is a code owner

Assignees

@zzstoatzz zzstoatzz

Labels
fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zzstoatzz @chrisguidry