Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow run retries for deployment flow runs #13884

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jun 7, 2024

Updates flow run engine to set the retries and delay on a flow run's empirical policy when a flow run is provided to the engine. This will fix flow run retries for flow runs created from a deployment.

Closes #13858

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in docs/mint.json navigation.

@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Jun 7, 2024
@desertaxle desertaxle marked this pull request as ready for review June 7, 2024 21:06
@desertaxle desertaxle requested a review from a team as a code owner June 7, 2024 21:06
src/prefect/client/orchestration.py Show resolved Hide resolved
src/prefect/flow_engine.py Show resolved Hide resolved
@desertaxle desertaxle merged commit b19bbde into main Jun 11, 2024
26 checks passed
@desertaxle desertaxle deleted the flow-run-retries-fix branch June 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flows are not retried after they fail when given a retries kwarg.
2 participants