Remove unused attributes from EngineContext
#13917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
approved these changes
Jun 12, 2024
Comment on lines
-394
to
-406
| # Tracking for objects created by this flow run | ||
| task_run_futures: List[PrefectFuture] = Field(default_factory=list) | ||
| task_run_states: List[State] = Field(default_factory=list) | ||
| # Tracking for result from task runs in this flow run | ||
| task_run_results: Dict[int, State] = Field(default_factory=dict) | ||
| flow_run_states: List[State] = Field(default_factory=list) | ||
|
|
||
| # The synchronous portal is only created for async flows for creating engine calls | ||
| # from synchronous task and subflow calls | ||
| sync_portal: Optional[anyio.abc.BlockingPortal] = None | ||
| timeout_scope: Optional[anyio.abc.CancelScope] = None | ||
|
|
||
| # Task group that can be used for background tasks during the flow run | ||
| background_tasks: anyio.abc.TaskGroup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the engine refactor, there are some attributes on the
EngineContextthat are used any longer. This PR removes them to avoid cruft and simplify the creation of aEngineContext.Closes #13951
Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
mint.jsonfor files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.jsonnavigation.