Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP events/React docs #13965

Merged
merged 15 commits into from
Jun 12, 2024
Merged

WIP events/React docs #13965

merged 15 commits into from
Jun 12, 2024

Conversation

LarryUllman
Copy link
Collaborator

@LarryUllman LarryUllman commented Jun 12, 2024

Starts editing the event/React docs for clarity and consistency. Still need to do the "Use automations for dynamic responses" page.

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intro, definition, and use case sections can be consolidated and pared down a bit. If we remove the image, we can get most of the text above the fold.

docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
docs/3.0rc/react/incidents.mdx Outdated Show resolved Hide resolved
discdiver and others added 9 commits June 12, 2024 15:07
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged @billpalombi's suggestions b/c I know you're OOO, @LarryUllman .

@discdiver discdiver merged commit 5ff6086 into main Jun 12, 2024
4 checks passed
@discdiver discdiver deleted the larry-docs-react branch June 12, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants