acquire/release token on TaskWorker without errors #14084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekaplan
changed the title
jakekaplan
commented
Jun 17, 2024
desertaxle
reviewed
Jun 17, 2024
Added! Let me know if its not what you had in mind |
jakekaplan
commented
Jun 17, 2024
| async with task_worker: | ||
| await asyncio.gather( | ||
| task_worker.execute_task_run(task_run), | ||
| task_worker.execute_task_run(task_run), |
There was a problem hiding this comment.
On main this errors with this borrower is already holding one of this CapacityLimiter's tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When acquiring or releasing a token we need to be sure to not propagate
RuntimeErrors so that theTaskWorkerkeeps running.