Adds a private status endpoint to TaskWorker
#14089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint, at `http://127.0.0.1:4422/status` reports the current state of the `TaskWorker`, including what its limiting parameters look like and which task runs of each key are currently in-flight. This is a rough-and-ready monitoring endpoint that we can flesh out with more info and tests as we go, but for now, we need it for load testing and reliability troubleshooting.
desertaxle
reviewed
Jun 17, 2024
chrisguidry
commented
Jun 17, 2024
| @sync_compatible | ||
| async def serve(*tasks: Task, limit: Optional[int] = 10): | ||
| async def serve( | ||
| *tasks: Task, limit: Optional[int] = 10, status_server_port: Optional[int] = None |
There was a problem hiding this comment.
@desertaxle how about this, two birds, one stone?
There was a problem hiding this comment.
That's a killer bird to stone ratio
desertaxle
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint, at
http://127.0.0.1:4422/statusreports the current state ofthe
TaskWorker, including what its limiting parameters look like and whichtask runs of each key are currently in-flight. This is a rough-and-ready
monitoring endpoint that we can flesh out with more info and tests as we go, but
for now, we need it for load testing and reliability troubleshooting.