Downgrade missing url log from warning to info #14108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
approved these changes
Jun 18, 2024
desertaxle
reviewed
Jun 18, 2024
src/prefect/utilities/urls.py
Outdated
| @@ -152,7 +152,7 @@ def url_for( | |||
| base_url = base_url or default_base_url | |||
|
|
|||
| if not base_url: | |||
| logger.warning( | |||
| logger.info( | |||
There was a problem hiding this comment.
I'd vote for this to be a debug-level log. It will likely show up on a user's first run and contains no info on how severe the issue is or how to resolve it. I see no upside to logging this to the user, but it is useful for internal users of this utility.
There was a problem hiding this comment.
I agree with that. There are other logs in this function that even emit ERROR level information that no URL could be generated, which I will also downgrade to debug. If they are truly errors, the function should error, but it returns None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log shows up very frequently when developing interactively, even when I have my log level set to WARNING, which I expect will only show me information that requires action or impairs performance. However, when developing or testing flows interactively, it is expected that no URL is available for the UI.