Move timeout context into slot acquisition service #14121
Merged
+84
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
Jun 18, 2024
Comment on lines
+105
to
+109
| if isinstance(response_or_exception, TimeoutError): | ||
| raise AcquireConcurrencySlotTimeoutError( | ||
| f"Attempt to acquire concurrency slots timed out after {timeout_seconds} second(s)" | ||
| ) from response_or_exception | ||
|
|
There was a problem hiding this comment.
raising a custom error here because the generic Scope timed out after ... message from timeout_async isnt so illuminating in this context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR moves the
timeout_asynccontext down into theacquire_slotsmethod of theConcurrencySlotAcquisitionServiceto ensure its scoped correctly.this has the bonus that we remove some duplication as
_acquire_concurrency_slotsis used by both thesyncandasyncioversions of theconcurrencycontext managerif this looks good ill port it to 2.x