Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly release workflow #14187

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Fix nightly release workflow #14187

merged 4 commits into from
Jun 20, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jun 20, 2024

Fixes issues with release notes generation by using the functionality build into the create release action. Also uses a custom PAT to ensure the downstream workflows start when the release is created.

Example

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Jun 20, 2024
@desertaxle desertaxle requested a review from a team as a code owner June 20, 2024 17:26
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me!

@desertaxle desertaxle merged commit 5a5f86b into main Jun 20, 2024
3 checks passed
@desertaxle desertaxle deleted the fix-nightly-release-workflow-5 branch June 20, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants