Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev GitHub environment for prereleases #14188

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jun 20, 2024

This PR updates our core release workflows to use the dev GitHub environment when the triggering release was a prerelease. With this change, the nightly release candidates will not need approval before being published to PyPI. This PR also adds a check of the tag before publishing to dev to ensure the new version will be a prerelease in PyPI.

Example

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@desertaxle desertaxle added the maintenance Chores and other work not directly related to the product label Jun 20, 2024
@desertaxle desertaxle requested a review from a team as a code owner June 20, 2024 18:27
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@desertaxle desertaxle merged commit 5baa7cc into main Jun 20, 2024
3 checks passed
@desertaxle desertaxle deleted the use-dev-for-prerelease branch June 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants