Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AzureResultHandler #1421

Merged
merged 3 commits into from
Aug 29, 2019
Merged

Conversation

frsann
Copy link

@frsann frsann commented Aug 29, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds AzureResultHandler for for handling results to / from Azure Blob storage containers.

Why is this PR important?

It helps users on the Azure platform to handle results.

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @frsann! 🎉 🎉

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1421 into master will decrease coverage by 0.17%.
The diff coverage is 76.56%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @frsann - I'm impressed! This is a clean implementation of a new result handler, and you covered all the standard issues. Very well done and thank you for the contribution!

@cicdw cicdw merged commit e710a74 into PrefectHQ:master Aug 29, 2019
abrookins added a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants