Backfill _all_ of the preceding events, in smaller batches and a limited time #14233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted time During my load testing of `TaskWorker`, I was able to narrow down one source of instability to missing events during a websocket reconnection. I realized that we were only partially backfilling events down the socket (limited to 1k) and that under moderate volume it was totally possible to miss events. Instead, we will clamp the backfill to 15 minutes worth of time and send _all_ of the matching events. Part of #14098
aaazzam
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my load testing of
TaskWorker, I was able to narrow down one source ofinstability to missing events during a websocket reconnection. I realized that
we were only partially backfilling events down the socket (limited to 1k) and
that under moderate volume it was totally possible to miss events. Instead,
we will clamp the backfill to 15 minutes worth of time and send all of the
matching events.
Part of #14098