Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Platform check to Local Agent #1441

Merged
merged 13 commits into from
Sep 6, 2019
Merged

Add Platform check to Local Agent #1441

merged 13 commits into from
Sep 6, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Sep 3, 2019 •
edited
Loading

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds a default platform check to the local agent for windows systems

Why is this PR important?

Multi-platform support

@joshmeek joshmeek added the DONT MERGE This PR shouldn't be merged (yet) label Sep 3, 2019
cicdw
cicdw requested changes Sep 3, 2019
View reviewed changes
src/prefect/agent/local/agent.py Outdated Show resolved Hide resolved
src/prefect/agent/local/agent.py Outdated Show resolved Hide resolved
@joshmeek joshmeek added component:agent Related to the flow submitting agent component:cli Related to the Prefect CLI and removed DONT MERGE This PR shouldn't be merged (yet) labels Sep 4, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #1441 into master will decrease coverage by 0.03%.
The diff coverage is 81.25%.

@cicdw
Copy link
Member

cicdw commented Sep 5, 2019

Holding off on this until we can definitively confirm that this agent will work on Windows machines.

@cicdw
Copy link
Member

cicdw commented Sep 6, 2019

LGTM pending the merge conflict

@joshmeek joshmeek merged commit cf9dcfd into master Sep 6, 2019
@cicdw cicdw mentioned this pull request Sep 6, 2019
Closed
@cicdw cicdw deleted the la_docker branch November 3, 2019 01:17
zanieb pushed a commit that referenced this pull request Mar 17, 2022
Merge pull request #1441 from PrefectHQ/orion-design-bump
58045ba 
Admin: Bumping orion-design version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
component:agent Related to the flow submitting agent component:cli Related to the Prefect CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshmeek @cicdw