-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise AuthorizationError on missing agent token #1459
Conversation
This looks really good @joshmeek ; only question I have is whether we want to raise an error if a token other than |
@cicdw We could do that, would require us to use something like |
@joshmeek you could query query {
authInfo {
apiTokenScope
}
} |
@jlowin Oh awesome! I'll add that |
Co-Authored-By: Jeremiah Lowin <153965+jlowin@users.noreply.github.com>
Co-Authored-By: Jeremiah Lowin <153965+jlowin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, def not requesting a change just want to make sure we cover any edge cases
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Adds an exception raise if no agent API token is provided
Closes #1454
Why is this PR important?
Helps avoid cases where an agent can deploy flows without providing an API token