-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove restriction on DotDict critical keys #1462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
requested changes
Sep 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean implementation that avoids the special keys, I like it - two minor suggestions
Co-Authored-By: Chris White <chris@prefect.io>
cicdw
approved these changes
Sep 7, 2019
zanieb
pushed a commit
that referenced
this pull request
Apr 13, 2022
Update link to running-parallel-tasks-with-dask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Previously, DotDicts were restricted from setting "critical" keys (such as
update
,items
, etc.) because they would shadowdict
methods. The only difference between aGraphQLResult
and aDotDict
was that this restriction was lifted and a different repr.However, in practice, this restriction is annoying and/or confusing.
This PR removes the restriction. The motivation for this PR was actually the discovery of a bug that
as_nested_dict
failed if aGraphQLResult
had anitems
key. This PR fixes the bug but in fixing it, I realized the restriction was obviously unhelpful since this bug slipped by anyway.Why is this PR important?