Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes Agent Liveness Probe #1474

Merged
merged 6 commits into from
Sep 9, 2019
Merged

Kubernetes Agent Liveness Probe #1474

merged 6 commits into from
Sep 9, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Sep 9, 2019 •
edited
Loading

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Why is this PR important?

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Sep 9, 2019
@joshmeek joshmeek changed the title Agent liveness Kubernetes Agent Liveness Probe Sep 9, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019 •
edited
Loading

Codecov Report

Merging #1474 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

cicdw
cicdw approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nicely done

src/prefect/agent/kubernetes/agent.py Show resolved Hide resolved
src/prefect/agent/kubernetes/agent.py Show resolved Hide resolved
src/prefect/agent/kubernetes/agent.py Show resolved Hide resolved
src/prefect/agent/kubernetes/deployment.yaml Show resolved Hide resolved
tests/agent/test_k8s_agent.py Show resolved Hide resolved
@joshmeek joshmeek merged commit 119b6ab into master Sep 9, 2019
@joshmeek joshmeek deleted the agent_liveness branch September 9, 2019 21:32
@cicdw cicdw mentioned this pull request Sep 11, 2019
Closed
zanieb pushed a commit that referenced this pull request Apr 13, 2022
@jakekaplan
Merge pull request #1474 from PrefectHQ/fix-broken-migration
77f4c3d 
Fix broken migration
@chuehsien chuehsien mentioned this pull request Jul 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshmeek @cicdw