Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fargate Agent #1521

Merged
merged 9 commits into from
Sep 17, 2019
Merged

Add Fargate Agent #1521

merged 9 commits into from
Sep 17, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Sep 17, 2019 •
edited

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds a new Fargate agent for deploying flows using tasks on AWS Fargate
Closes #1351

Documentation will be added async of this PR

Why is this PR important?

Fargate is a requested platform for support

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1521 into master will increase coverage by 0.01%.
The diff coverage is 94.44%.

cicdw
cicdw reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this looks great - I've got one rather large and annoying question.

Also - could you add this to docs/outline.toml?

src/prefect/agent/ecs/agent.py Outdated Show resolved Hide resolved
@joshmeek joshmeek changed the title Add ECS Agent Add Fargate Agent Sep 17, 2019
@joshmeek joshmeek merged commit 93ae3e3 into master Sep 17, 2019
@joshmeek joshmeek deleted the ecs branch September 17, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ECS agent
2 participants
@joshmeek @cicdw