Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On empty registry_url skip Docker Storage push and Local Agent pull #1525

Merged
merged 5 commits into from
Sep 17, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Sep 17, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Closes #1498 by skipping the push step of a Docker build if no registry URL is set. Also skip pull step of Local Agent if flow's storage has no registry URL set.

Why is this PR important?

We can now avoid the push/pull workarounds by simply providing registry_url="" to flow.deploy() (or Docker())

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1525 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@joshmeek joshmeek merged commit f09e73c into master Sep 17, 2019
@joshmeek joshmeek deleted the no_push branch September 17, 2019 20:22
zanieb pushed a commit that referenced this pull request Apr 13, 2022
…-ui/prefecthq/vue-compositions-0.1.19

Bump @prefecthq/vue-compositions from 0.1.18 to 0.1.19 in /orion-ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider a push an attribute on the Docker storage option
2 participants