Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent Platform Error Logs for Flow Runs #1528

Merged
merged 6 commits into from
Sep 18, 2019
Merged

Agent Platform Error Logs for Flow Runs #1528

merged 6 commits into from
Sep 18, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Sep 18, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Closes #1500
Logs possible platform errors that may arise when deploying a flow run

e.g. using the Fargate agent with the name of a cluster that does not exist at time of deploy:

image

Why is this PR important?

Makes some logs easier to see without having to go to the agent itself

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #1528 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This will be super helpful - and thanks for the solid tests, too 🚀

@joshmeek joshmeek merged commit ab3c03f into master Sep 18, 2019
@joshmeek joshmeek deleted the agent_error_logs branch September 18, 2019 15:37
zanieb pushed a commit that referenced this pull request Apr 13, 2022
…-ui/prefecthq/orion-design-0.1.65

Bump @prefecthq/orion-design from 0.1.63 to 0.1.65 in /orion-ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Agent Logging for Platform Roadblocks
2 participants