Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Blob Storage tasks #1538

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Conversation

frsann
Copy link

@frsann frsann commented Sep 20, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds Azure Blob Storage tasks.

Why is this PR important?

Azure Blob Storage users can upload and download stuff.

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @frsann! 🎉 🎉

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #1538 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Copy link

@joshmeek joshmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! Would you also mind adding this Task and yourself to CHANGELOG.md?

src/prefect/tasks/azure/blobstorage.py Show resolved Hide resolved
@frsann
Copy link
Author

frsann commented Sep 20, 2019

@joshmeek Sorry about that, totally forgot about it. Updated it in ee16fae.

Copy link

@joshmeek joshmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a great addition! Thanks @frsann

@joshmeek joshmeek merged commit c282a92 into PrefectHQ:master Sep 20, 2019
@dazzag24
Copy link

dazzag24 commented Sep 22, 2019

Hi,
Looks like a great addition.

One key improvement would be to allow users to use a SAS token rather than the ACCOUNT_KEY
e.g.

from azure.storage.blob import BlockBlobService

bs = BlockBlobService(account_name=<account_name>, sas_token=<sas_token>)

Using SAS tokens is considered more secure than having to share you ACCOUNT_NAME and ACCOUNT_KEY with potentially untrusted services. See more details here:

https://docs.microsoft.com/en-us/azure/storage/common/storage-sas-overview

See also the emulator that may be useful for testing without the cost implications of using real credentials.
https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azurite

Thanks

@joshmeek
Copy link

@dazzag24 Great suggestion! Feel free to open a feature request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants