Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Job Environment #1548

Merged
merged 10 commits into from
Sep 24, 2019
Merged

Kubernetes Job Environment #1548

merged 10 commits into from
Sep 24, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Sep 24, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds a KubernetesJobEnvironment which is very similar to how the DaskKubernetesEnvironment operates but it only deploys based on a single job spec.

Why is this PR important?

There are a myriad of possible k8s configuration options for deployments so we should expose an environment which allows for users to easily provide a job spec. This helps address (and will be documented in the future) priorities, eviction policies, resource requests, sidecars, etc... and adds more flexibility to deployments.

@joshmeek joshmeek added the enhancement An improvement of an existing feature label Sep 24, 2019
@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #1548 into master will decrease coverage by 0.01%.
The diff coverage is 90.76%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor name change tweaks, etc. -- this is a great addition to our environment library!!

src/prefect/environments/execution/k8s/job.py Outdated Show resolved Hide resolved
tests/environments/execution/test_k8s_job_environment.py Outdated Show resolved Hide resolved
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@joshmeek joshmeek merged commit e3b4236 into master Sep 24, 2019
@joshmeek joshmeek deleted the k8s_job_env branch September 24, 2019 22:04
zanieb added a commit that referenced this pull request Apr 13, 2022
Fix mark late runs service logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants