-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA Kubernetes Tasks #1559
QA Kubernetes Tasks #1559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome nice QA work; not going to Request Changes since I know this is touches a large number of tasks, but should we update the documentation anywhere to describe this pattern of setting the secret key to None
to enable a different connection option?
Yeah I’ll update the docstrings, good call |
…-flowrunstates Prevent transitions out of terminal states for flow run states
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
QA'd the k8s tasks and found that the API secret was required, adjusted so it can be provided as None. This required tests to be updates slightly. Also added tests for each task's in/out of cluster configuration connections.
Why is this PR important?
Secret was required and some connection options went untested