Add Parameter File Option to run cloud CLI command
#1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
requested changes
Oct 2, 2019
|
@cicdw The other (using click) would be to pass in a string representing a json payload. I'm fine with adding it if wanted but it seemed ugly at the time |
|
@cicdw I separated out a |
cicdw
reviewed
Oct 2, 2019
| string_params = json.loads(parameters_string) | ||
|
|
||
| flow_run_id = client.create_flow_run( | ||
| flow_id=flow_id, parameters={**file_params, **string_params} |
zanieb
pushed a commit
that referenced
this pull request
Apr 13, 2022
…-ui/vite-2.9.1 Bump vite from 2.8.6 to 2.9.1 in /orion-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Adds a
--parametersoption to theprefect run cloudCLI command for flow run parameter specification. Takes in a json file of parameters to use.I chose to go the route of providing a parameter file specification and am open to adding other methods if desired. This felt more natural.
Closes #1551
Why is this PR important?
Previously we were unable to specify parameters for this function