Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fargate Task Environment #1592

Merged
merged 16 commits into from
Oct 3, 2019
Merged

Fargate Task Environment #1592

merged 16 commits into from
Oct 3, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 3, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds the FargateTaskEnvironment
Closes #1549

Why is this PR important?

Works in a similar way to the KubernetesJobEnvironment by allowing users to specify completely custom task definitions for their flow runs

@joshmeek joshmeek added the enhancement An improvement of an existing feature label Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #1592 into master will increase coverage by <.01%.
The diff coverage is 95.31%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor typos and a question - nicely done!

@joshmeek joshmeek merged commit 128b1ce into master Oct 3, 2019
@joshmeek joshmeek deleted the fargate_environment branch October 3, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fargate Task Environment
2 participants