Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellTask Return all lines #1598

Merged
merged 3 commits into from
Oct 6, 2019
Merged

ShellTask Return all lines #1598

merged 3 commits into from
Oct 6, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Oct 5, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds a new return_all flag to the ShellTask for optionally returning all lines of stdout; also updates the Changelog following the 0.6.6 release.

Why is this PR important?

There are situations in which this is useful.

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #1598 into master will increase coverage by <.01%.
The diff coverage is 100%.

@cicdw cicdw merged commit 636a879 into master Oct 6, 2019
@cicdw cicdw deleted the return-all branch October 6, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants