Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug involving locally cached tasks and no schedule #1599

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Oct 7, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Flows which:

  • run with run_on_schedule=False
  • have a cached task
    would error out with:
AttributeError: 'Context' object has no attribute 'caches'

because of the place that we set this key. This PR moves that key-setting to a more universal location and adds a test.

Why is this PR important?

For local development and testing!

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #1599 into master will not change coverage.
The diff coverage is 100%.

@cicdw cicdw merged commit 8d1eb87 into master Oct 7, 2019
@cicdw cicdw deleted the fix-cache branch October 7, 2019 15:40
zanieb added a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants