Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optional "Name" to Agents #1612

Merged
merged 8 commits into from
Oct 15, 2019
Merged

Add Optional "Name" to Agents #1612

merged 8 commits into from
Oct 15, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 14, 2019 •
edited
Loading

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Closes #1611
Adds a name init arg to agents that can also be set through the AGENT_NAME environment variable

Why is this PR important?

Being able to name agents is a great tiny feature to have for division of work and clarity.

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Oct 14, 2019
jlowin
jlowin reviewed Oct 14, 2019
View reviewed changes
src/prefect/agent/agent.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 14, 2019 •
edited
Loading

Codecov Report

Merging #1612 into master will increase coverage by <.01%.
The diff coverage is 100%.

cicdw
cicdw requested changes Oct 15, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor request to be explicit about the name default from the CLI - otherwise this is great!

src/prefect/cli/agent.py Outdated Show resolved Hide resolved
@joshmeek joshmeek merged commit fddfede into master Oct 15, 2019
@joshmeek joshmeek deleted the agent_name branch October 15, 2019 18:19
zanieb pushed a commit that referenced this pull request Apr 13, 2022
@pleek91
Merge pull request #1612 from PrefectHQ/filter-stringify-name
0c60ff8 
UI: release orion-design 0.1.70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowin jlowin jlowin left review comments

@cicdw cicdw cicdw approved these changes

Assignees
No one assigned
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Optional "Name" to Agents
3 participants
@joshmeek @jlowin @cicdw