Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default fargate ARNs to empty string and relax logger warning #1634

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Default fargate ARNs to empty string and relax logger warning #1634

merged 2 commits into from
Oct 17, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 17, 2019 •
edited
Loading

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Updates the fargate agent to handle non-specified ARNs and relaxes the logger warning if not specified
Closes #1625
Closes #1624

Why is this PR important?

UX

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1634 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

cicdw
cicdw approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cicdw cicdw merged commit b2a7ef3 into master Oct 17, 2019
@cicdw cicdw deleted the fargate_default_kwargs branch October 17, 2019 14:57
zanieb pushed a commit that referenced this pull request Apr 13, 2022
Merge pull request #1634 from PrefectHQ/orion-design-bump
b5195bf 
Admin: Bumping orion-design version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Fargate Agent ARN to empty string instead of None Fargate agent warning is too aggressive
2 participants
@joshmeek @cicdw