Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Dependency Healthcheck #1653

Merged
merged 14 commits into from
Oct 23, 2019
Merged

Environment Dependency Healthcheck #1653

merged 14 commits into from
Oct 23, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 23, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Adds a new healthcheck for environment specific dependencies. These are exposed through the .dependencies property on environments

Closes #1623

Why is this PR important?

This allows us to remove some required dependencies from the docker storage build step and is a great notifier for users of certain environments

@joshmeek joshmeek added enhancement An improvement of an existing feature environment labels Oct 23, 2019
@joshmeek
Copy link
Author

joshmeek commented Oct 23, 2019

There are a couple of changelog commits because I had some wonky changelog "conflicts"

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1653 into master will decrease coverage by <.01%.
The diff coverage is 93.54%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog request, otherwise great implementation!

src/prefect/environments/storage/docker.py Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/prefect/agent/agent.py Outdated Show resolved Hide resolved
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! our deploys are going to get a whole lot better with this + @wagoodman 's work!

@joshmeek joshmeek merged commit 6b69821 into master Oct 23, 2019
@joshmeek joshmeek deleted the healthchecks branch October 23, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add healthcheck for Environments
2 participants