Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnvVarSecret #1683

Merged
merged 10 commits into from
Nov 2, 2019
Merged

Add EnvVarSecret #1683

merged 10 commits into from
Nov 2, 2019

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Oct 29, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds a new Secret class that pulls secret values from arbitrary environment variables. The values are treated as sensitive, due to the Secret subclass, but can be passed to any downstream task for processing / use. In addition, values can be cast to any appropriate type.

Why is this PR important?

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1683 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately I love this - it expands our secrets library and shows people how to work with their own custom secrets. I did make a lot of requests for documentation changes though

docs/core/concepts/secrets.md Outdated Show resolved Hide resolved
docs/core/concepts/secrets.md Outdated Show resolved Hide resolved
docs/core/concepts/secrets.md Outdated Show resolved Hide resolved
docs/core/concepts/secrets.md Outdated Show resolved Hide resolved
src/prefect/tasks/secrets/env_var.py Show resolved Hide resolved
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor typo-things, this LGTM otherwise!

CHANGELOG.md Outdated Show resolved Hide resolved
src/prefect/tasks/secrets/env_var.py Outdated Show resolved Hide resolved
@jlowin
Copy link
Member Author

jlowin commented Oct 31, 2019

Thanks @cicdw

@cicdw
Copy link
Member

cicdw commented Nov 1, 2019

@jlowin changelog conflicts

@cicdw cicdw merged commit cff30ba into master Nov 2, 2019
@cicdw cicdw deleted the env-var-secret branch November 2, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants