-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EnvVarSecret #1683
Add EnvVarSecret #1683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately I love this - it expands our secrets library and shows people how to work with their own custom secrets. I did make a lot of requests for documentation changes though
Co-Authored-By: Chris White <chris@prefect.io>
…into env-var-secret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor typo-things, this LGTM otherwise!
Thanks @cicdw |
@jlowin changelog conflicts |
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR adds a new
Secret
class that pulls secret values from arbitrary environment variables. The values are treated as sensitive, due to theSecret
subclass, but can be passed to any downstream task for processing / use. In addition, values can becast
to any appropriate type.Why is this PR important?