Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Fargate Agent defaults and env var parsing #1687

Merged
merged 5 commits into from Oct 30, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 30, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Updates the Fargate Agent boto3 access kwargs to default to None
Properly parses env vars that may be in forms such as lists and dicts

Why is this PR important?

Not providing certain access kwargs was failing on initialization of the boto3 client and not properly parsing certain env vars was rendering them useless

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Oct 30, 2019
@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #1687 into master will increase coverage by <.01%.
The diff coverage is 100%.

@joshmeek joshmeek merged commit de9378a into master Oct 30, 2019
@joshmeek joshmeek deleted the fargate_agent_defaults branch October 30, 2019 22:35
zanieb added a commit that referenced this pull request May 12, 2022
Change test harness example to session scoped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants