Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proactively fail flow runs if there is an issue with flows storage #1729

Merged
merged 5 commits into from
Nov 12, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Nov 12, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR proactively fails flow runs from the local docker agent if there are issues with the Flow's storage, including an image pull error.

Why is this PR important?

Previously we simply logged the error and waited for Lazarus to come along and reschedule the flow, which typically just results in the flow run eventually failing after some time. Users expect an image pull error to immediately translate to a flow run failure. Closes #1395

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1729 into master will decrease coverage by 0.03%.
The diff coverage is 55.55%.

@cicdw cicdw merged commit 675a03a into master Nov 12, 2019
@cicdw cicdw deleted the agent-fails branch November 12, 2019 16:44
zanieb pushed a commit that referenced this pull request May 12, 2022
…hub/codeql-action-2

Bump github/codeql-action from 1 to 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a flow has no storage attached, the agent should mark the run as failed
2 participants