Worker client fix #1750
Merged
Worker client fix #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeek
reviewed
Nov 18, 2019
joshmeek
approved these changes
Nov 19, 2019
jlowin
approved these changes
Nov 19, 2019
zanieb
pushed a commit
that referenced
this pull request
May 12, 2022
…-ui/typescript-4.6.4 Bump typescript from 4.6.3 to 4.6.4 in /orion-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR refactors how we manage background heartbeats from task / flow runs.
Why is this PR important?
It turns out that the old implementation of heartbeating led to non-deterministic deadlocks when using dask
worker_clients. Ultimately this boiled down to some complicated interaction between dask / requests / our Timer implementation. These deadlock situations would ultimately show themselves as Zombie Tasks in Prefect Cloud. The new implementation uses aThreadPoolExecutorto manage the thread and its associated state, which empirically has resolved the issue!