Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unique scheduler name for DaskKubernetesEnvironment #1772

Merged
merged 3 commits into from Nov 22, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Nov 22, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Similar to the default scheduler name, providing a custom scheduler spec will be given a unique name corresponding to the identifier_label

Why is this PR important?

This ensures that multiple flow runs can share the same scheduler spec and exist simultaneously without conflicting job names

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #1772 into master will increase coverage by <.01%.
The diff coverage is 100%.

@joshmeek joshmeek merged commit c043237 into master Nov 22, 2019
@joshmeek joshmeek deleted the dk8s_scheduler_spec_custom_name branch November 22, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants