Add Google Cloud Storage backend #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeek
reviewed
Dec 9, 2019
| def _gcs_client(self): # type: ignore | ||
| from google.cloud import storage | ||
|
|
||
| return storage.Client(project=self.project) |
There was a problem hiding this comment.
How are GCP creds handled with this? Does it require the user to log in outside of running this, creds in a known location, etc.?
There was a problem hiding this comment.
indeed, this requires the user to already have authenticated with the gcloud cli and make the credentials path available via the environment variable
joshmeek
reviewed
Dec 9, 2019
cicdw
previously approved these changes
Dec 9, 2019
joshmeek
reviewed
Dec 9, 2019
added 2 commits
December 9, 2019 12:20
cicdw
approved these changes
Dec 9, 2019
joshmeek
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Adds a new storage option for Google Cloud Storage.
Why is this PR important?
This allows the user to delegate flow storage to a remote backend.