Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass proper auth token to FargateTaskEnvironment execute tasks #1976

Merged
merged 5 commits into from Feb 3, 2020

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Feb 3, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Bug fix where proper auth token was not being passed to the task ran in the FargateTaskEnvironment's execute step

Why is this PR important?

Bug fixes are important :P

@joshmeek joshmeek added bug Something isn't working environment labels Feb 3, 2020
Co-Authored-By: Chris White <chris@prefect.io>
cicdw
cicdw previously approved these changes Feb 3, 2020
@joshmeek joshmeek merged commit 9110bd8 into master Feb 3, 2020
@joshmeek joshmeek deleted the pass_proper_token_fargate branch February 3, 2020 19:59
zanieb pushed a commit that referenced this pull request Jun 7, 2022
Cleanup and code review changes from integrating with nebula
@zanieb zanieb added fix A fix for a bug in an existing feature and removed bug Something isn't working labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants