Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of heartbeat config for Cloud #2081

Merged
merged 10 commits into from
Mar 16, 2020
Merged

Update name of heartbeat config for Cloud #2081

merged 10 commits into from
Mar 16, 2020

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Feb 25, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

The config options in Cloud have been renamed to have positive/descriptive values, so disable_heartbeat has become heartbeat_enabled.

The change is backwards-compatible, so old versions of Core will continue to function.

This PR should not be merged until this name change has been released to Cloud users.

@jlowin jlowin added the cloud label Feb 25, 2020
@jlowin jlowin marked this pull request as ready for review March 11, 2020 18:56
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #2081 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@jlowin
Copy link
Member Author

jlowin commented Mar 11, 2020

@joshmeek this can be merged anytime

cicdw
cicdw previously approved these changes Mar 11, 2020
@joshmeek joshmeek merged commit de485a3 into master Mar 16, 2020
@joshmeek joshmeek deleted the heartbeat-setting branch March 16, 2020 14:58
zanieb pushed a commit that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants