Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camelCase -> snake_case #2185

Merged
merged 24 commits into from
Mar 23, 2020
Merged

camelCase -> snake_case #2185

merged 24 commits into from
Mar 23, 2020

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Mar 22, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR does some major house cleaning to:

  • remove Client.deploy and flow.deploy
  • remove Client.write_run_log
  • converts most (but not all) all of our camelCased GraphQL calls to snake_cased calls

Note that we should manually test many of the changes here to make sure a breaking change doesn't sneak in accidentally.

Why is this PR important?

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #2185 into master will increase coverage by 0.05%.
The diff coverage is 81.39%.

src/prefect/agent/agent.py Show resolved Hide resolved
src/prefect/client/client.py Outdated Show resolved Hide resolved
src/prefect/client/client.py Show resolved Hide resolved
joshmeek
joshmeek previously approved these changes Mar 23, 2020
@cicdw cicdw merged commit f7f3f9b into master Mar 23, 2020
@cicdw cicdw deleted the some-snake-casing branch March 23, 2020 20:45
@zanieb zanieb mentioned this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove client.write_run_log Remove flow.deploy and client.deploy Convert all GraphQL calls to snake case
3 participants