Docs tweaks and a squashed bug #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
commented
Sep 26, 2018
| has been exceeded </li> | ||
| <li> `SKIP` will skip the task and possibly propogate the skip state through the | ||
| flow, depending on whether downstream tasks have `skip_on_upstream_skip=True`. </li></ul> | ||
| </li></ul> |
There was a problem hiding this comment.
Ok so this is up for debate; I put HTML directly into the docstring here so the list would format inside the table. I'm happy to remove this change though if we don't think it's appropriate.
There was a problem hiding this comment.
In this particular case I think it's appropriate to favor the docs because it's such an important method, and if that means HTML I'm all for it.
There was a problem hiding this comment.
That was my thought too, awesome
jlowin
approved these changes
Sep 26, 2018
| has been exceeded </li> | ||
| <li> `SKIP` will skip the task and possibly propogate the skip state through the | ||
| flow, depending on whether downstream tasks have `skip_on_upstream_skip=True`. </li></ul> | ||
| </li></ul> |
There was a problem hiding this comment.
In this particular case I think it's appropriate to favor the docs because it's such an important method, and if that means HTML I'm all for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155
Check out the netlify deploy build to see it in action!