Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better logging config #2340

Merged
merged 2 commits into from Apr 16, 2020
Merged

Better logging config #2340

merged 2 commits into from Apr 16, 2020

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Apr 16, 2020 •
edited

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR exposes config.logging.datefmt as a configurable setting on Prefect loggers.

Why is this PR important?

Community requested 馃殌 (also might help support logging data dog integrations)

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #2340 into master will not change coverage.
The diff coverage is 100.00%.

@joshmeek joshmeek merged commit a6f0eb1 into master Apr 16, 2020
@joshmeek joshmeek deleted the better-logging-config branch April 16, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowin jlowin jlowin approved these changes

@joshmeek joshmeek Awaiting requested review from joshmeek

@lauralorenz lauralorenz Awaiting requested review from lauralorenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cicdw @jlowin @joshmeek