Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use YAML safe command versions in server start CLI command #2352

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Apr 17, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Changes yaml load and dump to safe_load and safe_dump in the server start CLI command.

Why is this PR important?

https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

@joshmeek joshmeek added the cli Related to the Prefect CLI label Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #2352 into master will not change coverage.
The diff coverage is 100.00%.

@joshmeek joshmeek merged commit b5b85de into master Apr 17, 2020
@joshmeek joshmeek deleted the safe_yaml branch April 17, 2020 17:24
zanieb added a commit that referenced this pull request Jul 19, 2022
Fix bug with `lazy_import` and add handling for missing modules at import-time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the Prefect CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants