Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server start image version not using version kwarg #2435

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Fix server start image version not using version kwarg #2435

merged 2 commits into from
Apr 28, 2020

Conversation

joshmeek
Copy link

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Fixes a bug where the version kwarg on the server start CLI command wasn't being respected on tagged releases.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #2435 into master will not change coverage.
The diff coverage is n/a.

@joshmeek joshmeek merged commit eb59918 into master Apr 28, 2020
@joshmeek joshmeek deleted the test_bug branch April 28, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

@lauralorenz lauralorenz Awaiting requested review from lauralorenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshmeek @cicdw