Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop args out of log messages to prevent shipping non-JSON objects #2444

Merged
merged 1 commit into from Apr 29, 2020

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Apr 29, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR pops args out of the logs record dictionary to prevent them from being sent to Cloud (under the info payload). args are typically used to format log messages and otherwise not needed for log visibility / inspection in Cloud.

Why is this PR important?

Closes #2407 and helps ensure users don't need to change their logging code when running in Prefect.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #2444 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@joshmeek joshmeek merged commit b923e6d into master Apr 29, 2020
@joshmeek joshmeek deleted the log-json branch April 29, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging gives up too easily for non-JSON types
2 participants