Allow log configuration in Fargate Agent #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeschmid
requested review from
cicdw,
jlowin,
joshmeek and
lauralorenz
as code owners
abrookins
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not currently possible to enable AWS logging for Flow Runs launched with the Fargate Agent. This is a small change to allow
logConfigurationincontainerDefinitions, which enables logging, e.g. with AWS CloudWatch.CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)What does this PR change?
Adds the ability to include
logConfigurationinsidecontainerDefinitions.Why is this PR important?
The Fargate Agent can be complex to configure, especially when using it with an environment like
DaskCloudProviderEnvironment. Being able to examine logs for Flow runs can help with debugging configuration issues. Some users may also wish to capture and store logs for Flow runs in AWS CloudWatch.