Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker kwargs #2904

Merged
merged 6 commits into from Jul 2, 2020
Merged

Conversation

limx0
Copy link

@limx0 limx0 commented Jul 1, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • add a changelog entry in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Simply adds a container_name arg to CreateContainer. This allows starting/stopping/removing using a name rather than container_id, which is often more convenient.

Why is this PR important?

I have two separate flows that start and stop containers, this allows me to refer create/delete containers based on some name.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #2904 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@joshmeek
Copy link

joshmeek commented Jul 2, 2020

Thanks for the PR @limx0! Looks like you need to add the container_name to the docstring for your tasks. Could you also add this changelog entry to the changes/ directory under pr2904.yaml with the contents of something like:

task:
    - "Add `container_name` kwarg to `CreateContainer` Docker task - [#2904](https://github.com/PrefectHQ/prefect/pull/2904)"

contributor:
    - "[Bradley McElroy](https://github.com/limx0)"

(I would add it myself but looks like it won't let me make changes to this branch)

@limx0
Copy link
Author

limx0 commented Jul 2, 2020

Thanks @joshmeek, those few things are fixed now

@joshmeek joshmeek merged commit ac473c3 into PrefectHQ:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants