Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization Part II #318

Merged
merged 8 commits into from Nov 4, 2018
Merged

Serialization Part II #318

merged 8 commits into from Nov 4, 2018

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Nov 3, 2018

Continuing #310:

  • Uses new Schemas for Edge.serialize(), Task.serialize() and Flow.serialize()
  • Splits Schemas into separate files for clarity (core.py -> {flow.py, edge.py, task.py}) -- this will be mostly beneficial when there are multiple versions of schemas in the same file
  • Adds a new schema just for Parameters
  • Parameter classes now accept description and tags because why not?

NOTE: Cloud is not yet updated to ingest the output of Flow.serialize(). It should be a minor change since the payload is almost identical, but master/master integration will break with this PR until that is changed.

@jlowin jlowin mentioned this pull request Nov 3, 2018
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is looking

@jlowin jlowin merged commit 1e1f6f1 into master Nov 4, 2018
@joshmeek joshmeek deleted the serialization branch November 14, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants