Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NoSchedule and DateSchedule #324

Merged
merged 4 commits into from
Nov 6, 2018
Merged

Remove NoSchedule and DateSchedule #324

merged 4 commits into from
Nov 6, 2018

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Nov 4, 2018

Closes #321

@cicdw
Copy link
Member

cicdw commented Nov 4, 2018

See my comment about DateSchedule in #321 and you might want to change the name of the PR 😝

@jlowin
Copy link
Member Author

jlowin commented Nov 4, 2018

@jlowin jlowin changed the title Remove NoSchedule and IntervalSchedule Remove NoSchedule and DateSchedule Nov 4, 2018
cicdw
cicdw previously approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jlowin jlowin merged commit c243e1c into master Nov 6, 2018
@jlowin jlowin deleted the remove-schedules branch November 6, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeek joshmeek joshmeek approved these changes

@cicdw cicdw cicdw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlowin @cicdw @joshmeek