Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fargate Agent not handling int provided cpu and memory #3423

Merged
merged 3 commits into from Oct 2, 2020
Merged

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 2, 2020

Summary

Starting the fargate agent through the CLI could lead to issues in parsing of the cpu and memory values. This is due to the fact that boto3 required these values to be strings however natively they appear as integers. e.g.:

["prefect", "agent", "start", "fargate", "cpu=256", "memory=1024"]

Normally we exclude the literal parsing of these values because they are expected to be strings however we need to special case when they are actually provided as integers.

Importance

This fix will unblock some users attempting to do this however the new RunConfig pattern will completely resolve and simplify all of the Fargate agent parsing so much.

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@joshmeek joshmeek added the component:agent Related to the flow submitting agent label Oct 2, 2020
@joshmeek joshmeek requested a review from jcrist as a code owner October 2, 2020 15:20
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #3423 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@cicdw cicdw merged commit 87ef3ec into master Oct 2, 2020
@cicdw cicdw deleted the fa_patch branch October 2, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:agent Related to the flow submitting agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants