New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitLab storage #3461
Add GitLab storage #3461
Conversation
Awesome @madelgi! I'm going to test this against a GitLab repo to verify everything works but otherwise this looks really solid 🚀 |
@madelgi Tested and it worked flawlessly! Barring passing tests I think I am good to go on this! 🙂 |
@madelgi Could you also add this to the API reference documentation outline? (didn't catch this on my initial review) https://github.com/PrefectHQ/prefect/blob/master/docs/outline.toml#L228 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits and this looks good to me. Thanks!
Summary
Adds a
Gitlab
storage optionChanges
Adds a
Gitlab
storage option. Very similar to theGithub
storage option, though it allows two additional arguments:host
: For GitLab server users, can point to a local instance of GitLabref
: Required for the python GitLab client, points to the branch or commit hash where the file is located. Defaults tomaster
if not specifiedImportance
Expands the list of git-based storage options.
Checklist
This PR:
changes/
directory (if appropriate)docs/outline.toml
for API reference docs (if appropriate)