Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab storage #3461

Merged
merged 10 commits into from Oct 12, 2020
Merged

Conversation

madelgi
Copy link

@madelgi madelgi commented Oct 9, 2020

Summary

Adds a Gitlab storage option

Changes

Adds a Gitlab storage option. Very similar to the Github storage option, though it allows two additional arguments:

  • host: For GitLab server users, can point to a local instance of GitLab
  • ref: Required for the python GitLab client, points to the branch or commit hash where the file is located. Defaults to master if not specified

Importance

Expands the list of git-based storage options.

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@joshmeek
Copy link

joshmeek commented Oct 9, 2020

Awesome @madelgi! I'm going to test this against a GitLab repo to verify everything works but otherwise this looks really solid 🚀

@joshmeek
Copy link

joshmeek commented Oct 12, 2020

@madelgi Tested and it worked flawlessly! Barring passing tests I think I am good to go on this! 🙂

https://gitlab.com/joshmeek/prefect-flows

image

image

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #3461 into master will decrease coverage by 0.08%.
The diff coverage is 84.09%.

@joshmeek
Copy link

joshmeek commented Oct 12, 2020

@madelgi Could you also add this to the API reference documentation outline? (didn't catch this on my initial review) https://github.com/PrefectHQ/prefect/blob/master/docs/outline.toml#L228

Copy link

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits and this looks good to me. Thanks!

src/prefect/environments/storage/gitlab.py Outdated Show resolved Hide resolved
src/prefect/environments/storage/gitlab.py Outdated Show resolved Hide resolved
jcrist
jcrist previously approved these changes Oct 12, 2020
@joshmeek joshmeek merged commit fd38232 into PrefectHQ:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants