Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployments extension to AppsV1Api #3637

Merged
merged 4 commits into from Nov 10, 2020

Conversation

limx0
Copy link

@limx0 limx0 commented Nov 10, 2020

Summary

Fixes #3636

Changes

This PR updates the kubernetes tasks & utilities for deployments to AppsV1Api, which is required for newer cluster versions of kubernetes.

Importance

Refer #3636

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@limx0 limx0 changed the title Update jobs to AppsV1Api Update deployments extension to AppsV1Api Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #3637 (110d070) into master (4c764dd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@joshmeek
Copy link

Thanks @limx0 do you think you could add a /changes update for this?

Also adding that this closes #3195

@limx0
Copy link
Author

limx0 commented Nov 10, 2020

Certainly!

@joshmeek joshmeek merged commit d70bf76 into PrefectHQ:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes utilities are behind current server versions
2 participants